[6.0][Darwin][IR] Don't error on target_variant mismatch when linking IR #8777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lvm#92297) Change the ModuleFlag type for target_variant to warning to avoid error out when the value is different. This matches the linker behavior when linking object files. rdar://125874272 (cherry picked from commit 7c19058)
|
@swift-ci please test |
|
@swift-ci please test windows platform |
nkcsgexi
approved these changes
May 21, 2024
|
ping for a merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Make target-variant mismatch a warning when using LTO, matching linker behavior without LTO
Scope: Prevent hard error when target variant mismatches between object files
Issue: rdar://125874272
Original PR: llvm#92297
Reviewer: @cyndyishida
Risk: Low. Turn error into warning.
Test: Unit Test