[lldb] Calculate process address if file address + section fails #8849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
augusto2112
force-pushed
the
proc-address-lldb-mem-reader
branch
from
b0b2747 to
b642c3c
Compare
|
@swift-ci test |
augusto2112
force-pushed
the
proc-address-lldb-mem-reader
branch
from
b642c3c to
370bab6
Compare
|
Is it possible to write a test for this? |
kastiglione
reviewed
Jun 6, 2024
augusto2112
force-pushed
the
proc-address-lldb-mem-reader
branch
from
370bab6 to
bd503d4
Compare
If the resulting address from the Address constructor that takes a file address + offset fails, fallback to calculating the process address. rdar://128481320
augusto2112
force-pushed
the
proc-address-lldb-mem-reader
branch
from
bd503d4 to
1b147a2
Compare
Unfortunately I don't think that this is easily testable. |
kastiglione
approved these changes
Jun 7, 2024
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the resulting address from the Address constructor that takes a file address + offset fails, fallback to calculating the process address.
rdar://128481320