[lldb] Improve summary string handling of dollar chars #8961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the handling of `$` (dollar) characters in summary strings in the
following ways:
1. When a `$` is not followed by an open paren (`{`), it should be treated as a literal
character and preserved in the output. Previously, the dollar would be consumed by the
parser and not shown in the output.
2. When a `$` is the last character of a format string, this change eliminates the
infinite loop lldb would enter into.
rdar://131392446
(cherry picked from commit 10f3f06)
kastiglione
changed the title
|
@swift-ci test |
|
Use |
JDevlieghere
approved these changes
Jul 16, 2024
kastiglione
deleted the
dl/lldb-Improve-summary-string-handling-of-dollar-chars-98190
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the handling of
$(dollar) characters in summary strings in thefollowing ways:
$is not followed by an open paren ({), it should be treated as a literalcharacter and preserved in the output. Previously, the dollar would be consumed by the
parser and not shown in the output.
$is the last character of a format string, this change eliminates theinfinite loop lldb would enter into.
rdar://131392446
see llvm#98190
(cherry picked from commit 10f3f06)