Skip to content

[lldb] Don't crash on malformed filesets (#98388) #8972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

JDevlieghere
Copy link

The memory read can fail for a malformed fileset. Handle it gracefully instead of passing a nullptr to the std::string constructor.

rdar://131477833
(cherry picked from commit 919caa8)

The memory read can fail for a malformed fileset. Handle it gracefully
instead of passing a nullptr to the std::string constructor.

rdar://131477833
(cherry picked from commit 919caa8)
@JDevlieghere
Copy link
Author

@swift-ci test

@JDevlieghere
Copy link
Author

@swift-ci test windows

1 similar comment
@shahmishal
Copy link
Member

@swift-ci test windows

@jasonmolenda jasonmolenda self-assigned this Jul 15, 2024
@jasonmolenda jasonmolenda self-requested a review July 15, 2024 22:06
Copy link

@jasonmolenda jasonmolenda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JDevlieghere JDevlieghere merged commit 8988aa5 into swift/release/6.0 Jul 15, 2024
3 checks passed
@JDevlieghere JDevlieghere deleted the jdevlieghere/rdar/131477833 branch July 15, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants