[lldb] Change GetStartSymbol to GetStartAddress in DynamicLoader #8997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m#99909) On linux, the start address doesn't necessarily have a symbol attached to it. This is why this patch replaces `DynamicLoader::GetStartSymbol` with `DynamicLoader::GetStartAddress` instead to make it more generic. Signed-off-by: Med Ismail Bennani <[email protected]> (cherry picked from commit bb8a740)
|
@swift-ci test |
JDevlieghere
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On linux, the start address doesn't necessarily have a symbol attached to it.
This is why this patch replaces
DynamicLoader::GetStartSymbolwithDynamicLoader::GetStartAddressinstead to make it more generic.Signed-off-by: Med Ismail Bennani [email protected]
(cherry picked from commit bb8a740)