Improve the data formatter UX if an array is uninitialized. #9026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Global variables in Swift are lazy initialized and often zeroed out before the first access. This can be confusing to users, so this patch modifies the array dataformatter to recognize a null array. rdar://132736658
adrian-prantl
commented
Jul 29, 2024
| @@ -23,7 +23,7 @@ func main() { | |||
| var tb = Test() as Array + [] | |||
|
|
|||
| print("second stop") //% self.expect('frame variable -d run -- t', substrs=['t = 0x', 'NSArray = {', 'NSObject = {']) | |||
| //% self.expect('frame variable -d run -- ta', substrs=['ta = {', '_buffer = {', '_storage =', 'rawValue = 0x']) | |||
| //% self.expect('frame variable -d run -- ta', substrs=['ta = <uninitialized>', '_buffer = {', '_storage =', 'rawValue = 0x']) | |||
There was a problem hiding this comment.
Note that this test was basically showing that the formatter didn't work here before either.
|
@swift-ci test |
augusto2112
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Global variables in Swift are lazy initialized and often zeroed out before the first access. This can be confusing to users, so this patch modifies the array dataformatter to recognize a null array.
rdar://132736658