Skip to content

[Cherry-pick into stable/20240723] llvm-objdump: ensure a MachO symbol isn't STAB before looking up secion (#86667) #9142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

adrian-prantl
Copy link

commit 52337d5f9d108f04b2ed06069b21a255c232dc1f
Author: Tim Northover <[email protected]>
Date:   Thu Aug 15 19:19:30 2024 +0100

    llvm-objdump: ensure a MachO symbol isn't STAB before looking up secion (#86667)
    
    The section field has been repurposed for some STAB symbol types, and if
    we blindly look it up we'll produce an error and terminate. Logic
    already existed
    
    Existing stabs test had a section that was in range. Unfortunately I
    don't know of an easy way to produce stabs entries in LLVM (I thought
    they died in the 90s until this came up) so I just binary-edited it to
    cause a failure on existing llvm-objdump.

…on (llvm#86667)

The section field has been repurposed for some STAB symbol types, and if
we blindly look it up we'll produce an error and terminate. Logic
already existed

Existing stabs test had a section that was in range. Unfortunately I
don't know of an easy way to produce stabs entries in LLVM (I thought
they died in the 90s until this came up) so I just binary-edited it to
cause a failure on existing llvm-objdump.

(cherry picked from commit 52337d5)
@adrian-prantl adrian-prantl merged commit be99f87 into swiftlang:stable/20240723 Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants