[cherry-pick swift/release/6.0][clang][modules] Built-in modules are not correctly enabled for Mac Catalyst #9152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Explanation: This change is required for open source clang to be able to work with Mac Catalyst wit the SDKs in Xcode 16 beta 5 and beyond. (It will break compatibility for the earlier betas, but not the earlier releases.) |
cyndyishida
approved these changes
Aug 20, 2024
I forgot to update the version info in the SDKSettings file when I updated it to the real version relevant to the test.
…not correctly enabled for Mac Catalyst Mac Catalyst is the iOS platform, but it builds against the macOS SDK and so it needs to be checking the macOS SDK version instead of the iOS one. Add tests against a greater-than SDK version just to make sure this works beyond the initially supporting SDKs. rdar://116490661
ian-twilightcoder
force-pushed
the
builtin-modules-maccatalyst
branch
from
c6a7b9e to
a566c12
Compare
|
@swift-ci test llvm |
|
@swift-ci test |
|
LLVM errors are just the expected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mac Catalyst is the iOS platform, but it builds against the macOS SDK and so it needs to be checking the macOS SDK version instead of the iOS one. Add tests against a greater-than SDK version just to make sure this works beyond the initially supporting SDKs.
rdar://116490661