Skip to content

Add -fbuiltin-headers-in-system-modules to clang-scan-deps test #9195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

benlangmuir
Copy link

@benlangmuir benlangmuir commented Aug 29, 2024

One of the things this test is checking for is that builtin headers get the correct path in Darwin system modules. Add
-fbuiltin-headers-in-system-modules explicitly so that the test does not depend on the SDK version.

rdar://133239616
(cherry picked from commit 55d362b)


  • Explanation: Fixes a test when using SDKs that no longer enable -fbuiltin-headers-in-system-modules by default.
  • Scope: Test-only change.
  • Risk: Test-only
  • Testing: Tests passed
  • Issue: rdar://133239616
  • Reviewer: Fred

One of the things this test is checking for is that builtin headers get
the correct path in Darwin system modules. Add
-fbuiltin-headers-in-system-modules explicitly so that the test does not
depend on the SDK version.

rdar://133239616
(cherry picked from commit 55d362b)
@benlangmuir
Copy link
Author

@swift-ci please test

@benlangmuir benlangmuir requested a review from fredriss August 29, 2024 17:25
@benlangmuir
Copy link
Author

@swift-ci please test macOS

@benlangmuir
Copy link
Author

@swift-ci please test macOS

@bnbarham bnbarham merged commit 81a2745 into swiftlang:swift/release/6.0 Sep 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants