[lldb] Fix custom alignments of clang types which are members of Swift types being printed incorrectly #9246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of fixes for llvm#72913. clang emits `DW_AT_alignment` attribute, however LLDB didn't respect it, resulting in incorrect RecordDecls built by lldb. This only fixes non-inheritance cases. The inheritance case will be handled in a follow-up patch. (cherry picked from commit 439b16e)
Debug info generation won't emit the alignment of types that have a standard alignment. It was not taking into account the that case. rdar://127785973 (cherry picked from commit 3bf273f) (cherry picked from commit 87205b39392cd96e71fb876f1d9a2d80675e95d0)
|
@swift-ci test |
rdar://127785973
augusto2112
force-pushed
the
custom-align-fix-main
branch
from
6d24a33 to
935e266
Compare
|
@swift-ci test |
|
You should probably do this on |
|
Closing in favor of #9294 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks 2 changes from upstream LLVM ("Fix #pragma (packed, n) not emitting the alignment in debug info" and "[LLDB] Respect the DW_AT_alignment attribute.") and adds a test to ensure that Swift types who have a member which is a clang type with a custom alignment are printed correctly.
rdar://127785973