Skip to content

builtins: adjust code to build for ARM64 on MSVC #9279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

compnerd
Copy link
Member

Avoid the use of __attribute__ syntax on MSVC as that is not portable. For the weak symbol definition, use the MSVC extension of creating a weak alias through /alternatename.

Avoid the use of `__attribute__` syntax on MSVC as that is not portable.
For the weak symbol definition, use the MSVC extension of creating a
weak alias through `/alternatename`.
Copy link

@bnbarham bnbarham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just merge, if it fixes we can upstream.

@bnbarham bnbarham merged commit a860c72 into swiftlang:stable/20240723 Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants