Skip to content

[Coro] [async] Make sure to reprocess non-split async functions #9292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2024
Merged

[Coro] [async] Make sure to reprocess non-split async functions #9292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions llvm/lib/Transforms/Coroutines/CoroSplit.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2225,6 +2225,10 @@ PreservedAnalyses CoroSplitPass::run(LazyCallGraph::SCC &C,
UR.CWorklist.insert(&C);
for (Function *Clone : Clones)
UR.CWorklist.insert(CG.lookupSCC(CG.get(*Clone)));
} else if (Shape.ABI == coro::ABI::Async) {
// Reprocess the function to inline the tail called return function of
// coro.async.end.
UR.CWorklist.insert(&C);
}
}

Expand Down
29 changes: 29 additions & 0 deletions llvm/test/Transforms/Coroutines/coro-async.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,6 +497,35 @@ entry:
; CHECK: call void @use(ptr null)
; CHECK: ret

@simpleFuncTu = global <{i32, i32}> <{
i32 trunc (i64 sub (i64 ptrtoint (ptr @simpleFunc to i64),
i64 ptrtoint (ptr @simpleFuncTu to i64)) to i32), i32 16 }>

define swifttailcc void @simpleFunc(ptr swiftasync %0) presplitcoroutine {
entry:
%1 = alloca ptr, align 8
%2 = call token @llvm.coro.id.async(i32 16, i32 16, i32 0, ptr @simpleFuncTu)
%3 = call ptr @llvm.coro.begin(token %2, ptr null)
store ptr %0, ptr %1, align 8
%4 = load ptr, ptr %1, align 8
%5 = getelementptr inbounds <{ ptr, ptr }>, ptr %4, i32 0, i32 1
%6 = load ptr, ptr %5, align 8
%7 = load ptr, ptr %1, align 8
%8 = call i1 (ptr, i1, ...) @llvm.coro.end.async(ptr %3, i1 false, ptr @simpleFunc.0, ptr %6, ptr %7)
unreachable
}

; CHECK-LABEL: define swifttailcc void @simpleFunc(ptr swiftasync %0) {
; CHECK-NOT: define
; CHECK: [[RESUME:%.*]] = load ptr
; CHECK: musttail call swifttailcc void [[RESUME]]

define internal swifttailcc void @simpleFunc.0(ptr %0, ptr %1) alwaysinline {
entry:
musttail call swifttailcc void %0(ptr swiftasync %1)
ret void
}

declare { ptr, ptr, ptr, ptr } @llvm.coro.suspend.async.sl_p0i8p0i8p0i8p0i8s(i32, ptr, ptr, ...)
declare ptr @llvm.coro.prepare.async(ptr)
declare token @llvm.coro.id.async(i32, i32, i32, ptr)
Expand Down