[lldb] Support plain ObjC names in LLDBTypeInfoProvider #9320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augusto2112
reviewed
Sep 24, 2024
lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntimeDynamicTypeResolution.cpp
Show resolved
Hide resolved
lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntimeDynamicTypeResolution.cpp
Outdated
Show resolved
Hide resolved
augusto2112
approved these changes
Sep 26, 2024
| self, "// break here", lldb.SBFileSpec("main.swift") | ||
| ) | ||
| self.runCmd("settings set symbols.swift-enable-ast-context false") | ||
| self.expect("v", substrs=["num = 15"]) |
There was a problem hiding this comment.
Nit: Usually I prefer frame variable c over v since v is technically an alias, so there is a chance that it will be re-aliased later on to something else.
There was a problem hiding this comment.
it would be nice to have a policy on this. The v alias could change, but it would have to be a breaking change for a test like this to be a problem. A breaking change seems unlikely.
There was a problem hiding this comment.
There are other instances, I'll make a follow up change to catch them all.
kastiglione
deleted the
dl/lldb-Support-plain-ObjC-names-in-LLDBTypeInfoProvider
branch
kastiglione
added a commit
to swiftlang/swift
that referenced
this pull request
Sep 27, 2024
…ffset (#76678) This change is part of a fix for a regression that wasn't noticed because lldb has a fallback to using ASTContexts when type metadata resolution fails. For any Swift class that directly or indirectly inherits from an ObjC class (such as `NSObject`, `NSView`, etc), the function `computeUnalignedFieldStartOffset` will fail to compute the start offset. To compute the start offset, it traverses the parent classes and uses their sizes. Once the traversal reaches an ObjC class, the RemoteInspection does not know the size. The fix here is to get the size from the `TypeInfo` returned by the external `TypeInfoProvider` (which in LLDB is `LLDBTypeInforProvider`). Depended on by swiftlang/llvm-project#9320
|
It would be nice to squash follow-up fixes if they don't make sense on their own. Makes cherry-picking etc easier. |
|
Oh wait. This is even more confusing. You did! But Github only shows the original commits. |
adrian-prantl
pushed a commit
to adrian-prantl/llvm-project
that referenced
this pull request
Sep 27, 2024
Extend `LLDBTypeInfoProvider` to support ObjC class names (such as "NSObject", "NSView") in addition to mangled Swift names. This is to support `ObjCClassTypeRefs`, which contain the class name, but not the mangled name. Note that `ObjCClassTypeRefs` are typerefs for classes in the ObjC (`__C`) module. Depends on swiftlang/swift#76678 (cherry picked from commit 4a1abae)
adrian-prantl
added a commit
that referenced
this pull request
Sep 27, 2024
[lldb] Support plain ObjC names in LLDBTypeInfoProvider (#9320)
kastiglione
added a commit
that referenced
this pull request
Sep 30, 2024
Extend `LLDBTypeInfoProvider` to support ObjC class names (such as "NSObject", "NSView") in addition to mangled Swift names. This is to support `ObjCClassTypeRefs`, which contain the class name, but not the mangled name. Note that `ObjCClassTypeRefs` are typerefs for classes in the ObjC (`__C`) module. Depends on swiftlang/swift#76678 (cherry picked from commit 4a1abae)
kastiglione
added a commit
that referenced
this pull request
Sep 30, 2024
Extend `LLDBTypeInfoProvider` to support ObjC class names (such as "NSObject", "NSView") in addition to mangled Swift names. This is to support `ObjCClassTypeRefs`, which contain the class name, but not the mangled name. Note that `ObjCClassTypeRefs` are typerefs for classes in the ObjC (`__C`) module. Depends on swiftlang/swift#76678 (cherry picked from commit 4a1abae)
kastiglione
added a commit
that referenced
this pull request
Oct 4, 2024
This change is for two reasons: > prefer `frame variable` over `v` since `v` is technically an alias, so there is a chance that it will be re-aliased later on to something else. See #9320 (comment) Additionally, using `frame var` makes it easier to grep for than using `v`.
kastiglione
added a commit
that referenced
this pull request
Oct 29, 2024
This change is for two reasons: > prefer `frame variable` over `v` since `v` is technically an alias, so there is a chance that it will be re-aliased later on to something else. See #9320 (comment) Additionally, using `frame var` makes it easier to grep for than using `v`. (cherry-picked from commit ab5b104)
kastiglione
added a commit
that referenced
this pull request
Oct 29, 2024
This change is for two reasons: > prefer `frame variable` over `v` since `v` is technically an alias, so there is a chance that it will be re-aliased later on to something else. See #9320 (comment) Additionally, using `frame var` makes it easier to grep for than using `v`. (cherry-picked from commit ab5b104)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend
LLDBTypeInfoProviderto support ObjC class names (such as "NSObject", "NSView") in addition to mangled Swift names.This is to support
ObjCClassTypeRefs, which contain the class name, but not the mangled name. Note thatObjCClassTypeRefsare typerefs for classes in the ObjC (__C) module.Depends on swiftlang/swift#76678