Cp/r136659551 dont crash on malformed corefile #9344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Results in an assert at runtime, when run on an improperly formed corefile. rdar://136659551 (cherry picked from commit 3d04695)
lldb scans the corefile for dyld, the dynamic loader, and when it finds a mach-o header that looks like dyld, it tries to read all of the load commands and symbol table out of the corefile memory. If the load comamnds and symbol table are absent or malformed, it doesn't handle this case and can crash. Back out when we fail to create a Module from the dyld binary. rdar://136659551 (cherry picked from commit 0f98497)
jasonmolenda
deleted the
cp/r136659551-dont-crash-on-malformed-corefile
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.