[cherry-pick][stable/20240723] [lldb][TypeSystemClang] Add warning and defensive checks when ASTContext is not fully initialized #9361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this comment around target initialization implies:
There are cases where we might fail to call
InitBuiltinTypes
when creating the backingASTContext
for aTypeSystemClang
. If that happens, the builtinsQualType
s, e.g.,VoidPtrTy
/IntTy
/etc., are not initialized and dereferencing them as we do inGetBuiltinTypeForEncodingAndBitSize
(and other places) will lead to nullptr-dereferences. Example backtrace:This patch adds a one-time user-visible warning for when we fail to initialize the AST to indicate that initialization went wrong for the given target. Additionally, we add checks for whether one of the
ASTContext
QualType
s is invalid before dereferencing any builtin types.The warning would look as follows:
rdar://134869779
(cherry picked from commit a5f3a2a)