[lldb] Introduce precise Fallback SwiftASTContexts. #9382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
adrian-prantl
requested review from
kastiglione and
augusto2112
and removed request for
JDevlieghere and
kastiglione
adrian-prantl
force-pushed
the
137087616
branch
2 times, most recently
from
84de0e7 to
700aecf
Compare
|
@swift-ci test |
augusto2112
reviewed
Oct 5, 2024
adrian-prantl
force-pushed
the
137087616
branch
from
700aecf to
45d297c
Compare
|
@swift-ci test |
When we switched to precise compiler invocations, we still kept the per-module fallback SwiftASTContext. This can be a problem when also using explicit modules, because explicit module imports only work with precise compiler invocations. This patch changes TypeSystemSwiftTyperef to pass its SymbolContext when creating its fallback SwiftASTContext. This basically turns on precise compiler invocationsfor fallback contexts. The price is more compiler instances, but this is only way to make them work reliably with explicit modules. rdar://137087616
|
@swift-ci test |
adrian-prantl
force-pushed
the
137087616
branch
from
45d297c to
96d93d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we switched to precise compiler invocations, we still kept the per-module fallback SwiftASTContext. This can be a problem when also using explicit modules, because explicit module imports only work with precise compiler invocations. This patch changes
TypeSystemSwiftTyperef to pass its SymbolContext when creating its fallback SwiftASTContext. This basically turns on precise compiler invocationsfor fallback contexts. The price is more compiler instances, but this is only way to make them work reliably with explicit modules.
rdar://137087616