[lldb] Check runtime dependencies of SwiftREPL tests in local lit config #9421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjyamauchi
reviewed
Oct 16, 2024
hjyamauchi
approved these changes
Oct 16, 2024
…lit config These binaries only exists if the Swift runtime was built correctly. We cannot check them at configuration time, because they might not exist yet.
weliveindetail
force-pushed
the
lldb-test-swiftrepl-runtime-deps
branch
from
36718d5 to
54c7f58
Compare
weliveindetail
requested review from
daniel-grumberg,
keith and
dcci
as code owners
|
To all the new reviewers: sorry for the noise, I had to update the base branch |
|
@swift-ci please test |
|
Thanks for giving it a try! Rebranch linux bot is still broken. |
|
@swift-ci please test Linux Platform |
|
@swift-ci please test Windows Platform |
|
The issue with |
|
This will be part of #9513 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SwiftREPL tests run
repl_swift.exe, which manually loads a few external dependencies at runtime. In particular swiftCore.dll and swiftrt.obj.These binaries need to be in fixed locations and they only exists if the Swift runtime was built correctly. We cannot check them at configuration time, because they might not exist yet. It seems worth checking whether they exist and printing a warning otherwise, because the resulting test failures aren't very obvious.