Skip to content

[DebugInfo] Remove spare bits mask from LLVM IR and DWARF #9466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

augusto2112
Copy link

We are able to calculate the spare bits mask from other information. Remove this from the LLVM IR representation and DWARF.

@augusto2112
Copy link
Author

swiftlang/swift#77176
@swift-ci test

2 similar comments
@augusto2112
Copy link
Author

swiftlang/swift#77176
@swift-ci test

@augusto2112
Copy link
Author

swiftlang/swift#77176
@swift-ci test

@augusto2112 augusto2112 force-pushed the remove-spare-bits-debug-2 branch from 0d5b09f to 78810b9 Compare November 5, 2024 00:40
@augusto2112
Copy link
Author

swiftlang/swift#77176
@swift-ci test

Copy link

@adrian-prantl adrian-prantl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but can you add a test that shows we can "upgrade" the old format by ignoring the attribute?

We are able to calculate the spare bits mask from other information.
Remove this from the LLVM  IR representation and DWARF.
@augusto2112 augusto2112 force-pushed the remove-spare-bits-debug-2 branch from 78810b9 to a1bc710 Compare November 6, 2024 02:08
@augusto2112
Copy link
Author

swiftlang/swift#77176
@swift-ci test

@augusto2112 augusto2112 merged commit 28dfa53 into swiftlang:stable/20240723 Nov 6, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants