Skip to content

[lldb] Thread mangling flavor together with node pointer #9496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

augusto2112
Copy link

@augusto2112 augusto2112 commented Oct 31, 2024

LLDB performs many analysis as transformations by converting a mangled
name into a demangle tree and later on back to a mangled name.
Unfortunately there's no cheap way for a demangle tree to carry its
mangled name's mangling flavor. This patch threads the mangling flavor
along with the demangle tree so when converting a demangle tree back to
a mangled name we reconstruct it with the same mangling flavor as the
original type.

LLDB performs many analysis as transformations by converting a mangled
name into a demangle tree and later on back to a mangled name.
Unfortunately there's no cheap way for a demangle tree to carry its
mangled name's mangling flavor. This patch threads the mangling flavor
along with the demangle tree so when converting a demangle tree back to
a mangled name we reconstruct it with the same mangling flavor as the
original type.
@augusto2112 augusto2112 marked this pull request as ready for review December 5, 2024 23:36
@augusto2112 augusto2112 requested a review from a team as a code owner December 5, 2024 23:36
@augusto2112
Copy link
Author

@swift-ci test

@augusto2112 augusto2112 changed the title [lldb][WIP] Draft change on adapting LLDB to mangling flavor [lldb] Thread mangling flavor together with node pointer Dec 5, 2024
@kubamracek
Copy link

@swift-ci test Windows platform

1 similar comment
@kubamracek
Copy link

@swift-ci test Windows platform

@adrian-prantl
Copy link

I have one rather fundamental question. Instead of threading this through as a parameter, should embedded Swift be a separate Language with a separate TypeSystemSwift instance (that uses the same implementation, but hardcodes the flavor)?
If we never intend to mix&match between the two, why try to have one typesystem instance deal with both?

@kubamracek
Copy link

@swift-ci test

2 similar comments
@kubamracek
Copy link

@swift-ci test

@augusto2112
Copy link
Author

@swift-ci test

@kubamracek
Copy link

@swift-ci test macOS platform

@augusto2112 augusto2112 merged commit 9839c20 into swiftlang:stable/20240723 Dec 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants