Suppress warnings for Swift C++ interop by hiding operator declarations #9521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change, the Swift compiler build is fully of spammy warnings like this:
```
.../DependentDiagnostic.h:152:8: warning: cycle detected while resolving 'ddiag_iterator' in swift_name attribute for 'operator=='
bool operator==(ddiag_iterator Other) const {
^
.../DependentDiagnostic.h:127:20: note: while resolving 'DeclContext' in swift_name attribute for 'ddiag_iterator'
class DeclContext::ddiag_iterator {
^
.../DependentDiagnostic.h:152:8: note: please report this issue to the owners of 'Clang_AST.DeclBase'
bool operator==(ddiag_iterator Other) const {
^
```
tshortli
force-pushed
the
suppress-swift-cxx-interop-cycle-warnings
branch
from
e3ed6e3 to
3ce6236
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, the Swift compiler build is fully of spammy warnings like this: