[lldb] Implement support for Clang Submodule imports in Swift contexts. #9532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is legal to import a Clang submodule using Module.Submodule syntax. LLDB was not handling this correctly when doing contextual imports and stripped everything but the base name. rdar://137003294
adrian-prantl
requested review from
augusto2112 and
kastiglione
and removed request for
JDevlieghere
|
I apologize for the slightly orthogonal conversion to llvm::Expected that I did en passant. |
|
@swift-ci test |
|
There "real" change is that we now use "A.B" as the index in the Swift module map instead of "A". |
augusto2112
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is legal to import a Clang submodule using Module.Submodule syntax. LLDB was not handling this correctly when doing contextual imports and stripped everything but the base name.
rdar://137003294