[lldb] Retire the Swift-specific scratch context accessors #9615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that all scratch contexts are using precise per-CU compiler invocations, the infrastructure for the per-module fallback scratch context is no longer needed, since it is actually less precise than the "normal" contexts. This patch removes the notion of a fallback SwiftASTContext entirely.
This mechanism was put into place to deal with SwiftASTContexts being torn down and replaced. While that may still happen, we no have a much better solution for the problem of dangling type references: CompilerType now holds a weak_ptr to the type system so it's safe to destroy a type system.
adrian-prantl
requested review from
augusto2112,
kastiglione and
JDevlieghere
and removed request for
JDevlieghere
|
@swift-ci test |
adrian-prantl
force-pushed
the
retire-createswiftscratchcontext
branch
2 times, most recently
from
97a0f57 to
deb7ae9
Compare
|
@swift-ci test |
These used to be necessary because there used to be context-specific scratch contexts, however, now there is only one global TypeSystemSwiftTypeRefForExpressions, and it manages multiple SwiftASTContexts. Therefore it is no longer necessary to have Swift-specific hooks in Target and ValueObject.
adrian-prantl
force-pushed
the
retire-createswiftscratchcontext
branch
from
deb7ae9 to
927f129
Compare
|
@swift-ci test |
adrian-prantl
merged commit 698b909
into
swiftlang:stable/20240723
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These used to be necessary because there used to be context-specific
scratch contexts, however, now there is only one global
TypeSystemSwiftTypeRefForExpressions, and it manages multiple
SwiftASTContexts. Therefore it is no longer necessary to have
Swift-specific hooks in Target and ValueObject.
depends on #9613