[lldb][swift] Add support for async_let step-over #9628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipepiovezan
requested review from
adrian-prantl
and removed request for
JDevlieghere
This will enable us to share code and handle more functions similar to swift_task_switch in a subsequent commit.
The use of `async let` in swift introduces two new trampolines that may trigger a task switch: 1. `swift_asyncLet_get`, which gets called upon `await`ing an `async let` variable. 2. `swift_asyncLet_finish`, which gets called when the `async let` variable goes out of scope. We need step through plans for both of those.
felipepiovezan
force-pushed
the
felipe/fix_async_let_step_over
branch
from
aa4ea85 to
405a791
Compare
|
@swift-ci test |
adrian-prantl
approved these changes
Nov 19, 2024
| import lldbsuite.test.lldbutil as lldbutil | ||
|
|
||
|
|
||
| @skipIfAsan # rdar://138777205 |
There was a problem hiding this comment.
Oh, good point, it shouldn't be needed anymore. There are a handful of tests with this annotation, so I'll merge this as is and post another PR to remove all of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting stepping over
async letconstructs require knowledge about two new trampolines, which are described in the second commit here.The first NFC commit factors out some code to minimize the diff of the second commit and enable code re-use.