[lldb] Acquire the map lock after deriving the lookup key #9636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The computation of the key may itself does DWARF lookups which may acquire additional locks through callbacks into TypeSystem. rdar://139841554
|
@swift-ci test |
jimingham
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
LGTM. IIUC you would be holding the lock over the call DeriveKeyFor because you wanted that method not to remove information about the SC from the SwiftASTContextMap. That seems like a very odd thing for DeriveKeyFor(SC) to do, so holding the lock while calling it should not be necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The computation of the key may itself does DWARF lookups which may acquire additional locks through callbacks into TypeSystem.
rdar://139841554