[clang] Fix lifetimebound APINotes tests #9653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test LLVM |
egorzhdan
reviewed
Nov 21, 2024
|
I did not isolate the commit yet that causes the difference, but I don't think there is anything that would prevent us from doing that. It is more just the matter of allocating time for that. |
|
I talked to @egorzhdan offline and the code changes make sense to upstream (PR opened: llvm#117194). There is a smaller test-only change that make sense to do downstream for now, will update this PR. |
Xazax-hun
force-pushed
the
gaborh/duplicate-lifetimebound
branch
from
13dec4d to
5f891eb
Compare
The APINotes implementation upstream and downstream are not exactly the same, this PR makes sure the lifetimebound type attribute for 'this' object is deduplicated, and updates the test to respect versioned attributes. rdar://140295698
Xazax-hun
force-pushed
the
gaborh/duplicate-lifetimebound
branch
from
5f891eb to
eb39ee7
Compare
|
@swift-ci please test LLVM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The APINotes implementation upstream and downstream are not exactly the same, this PR makes sure the lifetimebound type attribute for 'this' object is deduplicated, and updates the test to respect versioned attributes.
rdar://140295698