Skip to content

[cmake] Switch index store flag to opt-in #9684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hamishknight
Copy link

Enabling by default for debug builds is problematic for those using sccache since it prevents caching. Switch to being opt-in for those that need it.

Enabling by default for debug builds is problematic
for those using sccache since it prevents caching.
Switch to being opt-in for those that need it.
@hamishknight hamishknight requested a review from a team as a code owner December 3, 2024 23:02
@hamishknight
Copy link
Author

@swift-ci please test

@DougGregor
Copy link
Member

Enabling by default for debug builds is problematic for those using sccache since it prevents caching. Switch to being opt-in for those that need it.

Isn't this the basis for a lot of IDE functionality we depend on, e.g., go-to-definition?

@akyrtzi
Copy link

akyrtzi commented Dec 3, 2024

Isn't this the basis for a lot of IDE functionality we depend on, e.g., go-to-definition?

No, the background indexer will produce the data even if there is no index-while-building data present.

@hamishknight hamishknight merged commit 1e89914 into swiftlang:stable/20240723 Dec 4, 2024
3 checks passed
@hamishknight hamishknight deleted the opt-in-index-data branch December 4, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants