[6.1] [cas] Definitions from unimported submodules should not be visible #9722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 66228ed a merge conflict was incorrectly resolved leading to modules built with caching to expose definitions that come from unimported submodules to codegen. This would then cause linking errors if multiple TUs imported any part of that module. rdar://131028078 (cherry picked from commit e511172)
|
@swift-ci please test |
nkcsgexi
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: In 66228ed a merge conflict was incorrectly resolved leading to modules built with caching to expose definitions that come from unimported submodules to codegen. This would then cause linking errors if multiple TUs imported any part of that module.
Scope: Affects modules built with caching enabled.
Issues: rdar://131028078
Original PR: #9716
Risk: Low. This reverts to the previous behaviour. Only caching builds involving modules are affected.
Testing: New tests added
Reviewed by: @cachemeifyoucan