[lldb][Target] Remove BoundsSafetyTrapFrameRecognizer #9724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael137
requested review from
delcypher,
adrian-prantl,
rapidsna and
danliew-apple
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
adrian-prantl
approved these changes
Dec 12, 2024
`VerboseTrapFrameRecognizer` recognizes `__builtin_verbose_trap`
frames, which is used in newer versions of `-fbounds-safety`.
This makes `BoundsSafetyTrapFrameRecognizer` redundant. This patch
removes it (but makes sure `VerboseTrapFrameRecognizer` still recognizes
the old `-fbounds-safety` frame-names).
This also fixes the test failure on Swift CI currently we currently
incorrectly pick the `BoundsSafetyTrapFrameRecognizer` because
the `__builtin_verbose_trap` message contains the string `Bounds check
failed`:
```
/Users/ec2-user/jenkins/workspace/oss-lldb-incremental-macos-cmake/llvm-project/lldb/test/Shell/BoundsSafety/boundssafetytrap.test:5:10: error: CHECK: expected string not found in input
^
<stdin>:1:1: note: scanning from here
(lldb) command source -s 0 '/Users/ec2-user/jenkins/workspace/oss-lldb-incremental-macos-cmake/build/Ninja-ReleaseAssert+stdlib-Release/lldb-macosx-x86_64/test/Shell/lit-lldb-init-quiet'
^
<stdin>:11:69: note: possible intended match here
* thread #1, queue = 'com.apple.main-thread', stop reason = __clang_trap_msg$Bounds check failed$Dereferencing above bounds
^
```
Michael137
force-pushed
the
lldb-remove-bounds-safety-recognizer
branch
from
8375462 to
c4264d6
Compare
rapidsna
approved these changes
Dec 13, 2024
This should pass now that we removed the `BoundsSafetyTrapFrameRecognizer` in favour of the `VerboseTrapFrameRecognizer`
|
@swift-ci test |
Michael137
added a commit
that referenced
this pull request
Feb 6, 2025
These pass ever since we've fixed the frame recognizer in #9724. rdar://141363609
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VerboseTrapFrameRecognizerrecognizes__builtin_verbose_trapframes, which is used in newer versions of-fbounds-safety.This makes
BoundsSafetyTrapFrameRecognizerredundant. This patch removes it (but makes sureVerboseTrapFrameRecognizerstill recognizes the old-fbounds-safetyframe-names).This also fixes the test failure on Swift CI currently we currently incorrectly pick the
BoundsSafetyTrapFrameRecognizerbecause the__builtin_verbose_trapmessage contains the stringBounds check failed: