[lldb] Resolve typealias information for assiciated types via reflection #9768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian-prantl
force-pushed
the
140940434
branch
from
050d894 to
a269a9b
Compare
|
@swift-ci test |
adrian-prantl
requested review from
kastiglione,
JDevlieghere and
augusto2112
augusto2112
approved these changes
Dec 19, 2024
| if (!reflection_ctx) | ||
| return {}; | ||
|
|
||
| Progress progress("Downloading Swift conformances"); |
There was a problem hiding this comment.
Maybe "parsing" instead of "downloading"?
lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntimeDynamicTypeResolution.cpp
Outdated
Show resolved
Hide resolved
lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntimeDynamicTypeResolution.cpp
Outdated
Show resolved
Hide resolved
lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntimeDynamicTypeResolution.cpp
Outdated
Show resolved
Hide resolved
| if (!reflection_ctx) | ||
| return {}; | ||
|
|
||
| Progress progress("Downloading Swift conformances"); |
adrian-prantl
force-pushed
the
140940434
branch
2 times, most recently
from
7c3ac2f to
3199d3e
Compare
In this testcase there is an associated type for which no debug info is generated, since there is neither function nor a variable holding on to it. However, the associated type information is stored in the Witness Table, which we can query in the runtime. rdar://140940434
adrian-prantl
force-pushed
the
140940434
branch
from
3199d3e to
a098c18
Compare
|
@swift-ci test |
JDevlieghere
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this testcase there is an associated type for which no debug info
is generated, since there is neither function nor a variable holding
on to it. However, the associated type information is stored in the
Witness Table, which we can query in the runtime.
rdar://140940434