Skip to content

[lldb] Adjust to swift::SearchPathOptions enhancing the ImportSearchPaths type #9780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ian-twilightcoder
Copy link

@ian-twilightcoder ian-twilightcoder commented Dec 20, 2024

swift::SearchPathOptions renamed FrameworkSearchPath to SearchPath and uses it for both ImportSearchPaths and FrameworkSearchPaths.

rdar://141967997

@ian-twilightcoder
Copy link
Author

ian-twilightcoder commented Dec 23, 2024

Goes with swiftlang/swift#78303 (running CI in that PR)

@ian-twilightcoder ian-twilightcoder force-pushed the swift-import-paths branch 2 times, most recently from 55ba72e to 5aea4f9 Compare December 23, 2024 23:20
@ian-twilightcoder ian-twilightcoder marked this pull request as ready for review December 23, 2024 23:20
@ian-twilightcoder ian-twilightcoder requested review from cachemeifyoucan and removed request for JDevlieghere December 23, 2024 23:21
@ian-twilightcoder ian-twilightcoder changed the title Adjust to swift::SearchPathOptions enhancing the ImportSearchPaths type [lldb] Adjust to swift::SearchPathOptions enhancing the ImportSearchPaths type Dec 23, 2024
…aths type

swift::SearchPathOptions renamed FrameworkSearchPath to SearchPath and uses it for both ImportSearchPaths and FrameworkSearchPaths.

rdar://141967997
Copy link

@adrian-prantl adrian-prantl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that's great. That duplicated type was quite unnecessary :-)

@ian-twilightcoder ian-twilightcoder merged commit 6343230 into swiftlang:next Jan 6, 2025
@ian-twilightcoder ian-twilightcoder deleted the swift-import-paths branch January 6, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants