[Clang][Driver] Add arm64e support for Swift’s "-none-macho" target triples in Clang Driver #9824
Conversation
…riples in Clang Driver This change moves arm64e pointer authentication flag computation the the DarwinClang toolchain to the base MachO toolchain. This makes the logic apply to all Mach-O target triples, not just Darwin ones.
|
@swift-ci please test |
There was a problem hiding this comment.
You'll probably want this in next as well, right? I can believe that the swift test would be a bit more of a pain there; you'd probably be better off having a test here in clang/test/Driver/arch-arm64e.c anyway, with maybe just some DEFAULT-MACHO for arm64e-apple-none-macho?
|
Test added. I also had to do a small fixup of the test as it seems to be failing -- it expected that the -target-cpu flag is right after the ptrauth flags in the output, but that's not the case. Not sure why or if this was the case in the past and it's not anymore? |
|
@swift-ci please test |
|
"next": #9846 |
|
@swift-ci please smoke test macOS platform |
3 similar comments
|
@swift-ci please smoke test macOS platform |
|
@swift-ci please smoke test macOS platform |
|
@swift-ci please smoke test macOS platform |
|
@swift-ci please test macOS platform |
This change moves arm64e pointer authentication flag computation from the DarwinClang toolchain to the base MachO toolchain. This makes the logic apply to all Mach-O target triples, not just Darwin ones.
Test for this in the Swift repo: swiftlang/swift#78613
rdar://141676141