[clang][cas] Avoid calling freezeConfig for every cache key #9831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlangmuir
commented
Jan 14, 2025
benlangmuir
commented
- Explanation: With the libclang caching APIs, it is possible to configure CASOptions separately from the CAS used for scanning. In this setup, the CAS is not pre-cached in the CASOptions and ends up being re-opened for every cache key, which is expensive with some plugin CAS. Instead, get the hash identifier from the already open CAS and only freezeConfig when canonicalizing for an actual compilation.
- Scope: Affects caching builds.
- Issue/Radar: rdar://141555438
- Original PR: [clang][cas] Avoid calling freezeConfig for every cache key #9803
- Risk: Low. Should not change behaviour, only performance. Only affects caching builds.
- Testing: Existing regression tests pass.
- Reviewer: @akyrtzi
With the libclang caching APIs, it is possible to configure CASOptions separately from the CAS used for scanning. In this setup, the CAS is not pre-cached in the CASOptions and ends up being re-opened for every cache key, which is expensive with some plugin CAS. Instead, get the hash identifier from the already open CAS and only freezeConfig when canonicalizing for an actual compilation. rdar://141555438 (cherry picked from commit 3c460cc)
|
@swift-ci please test |
fredriss
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.