Skip to content

Pick Vector Dotproduct improvements. #9858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

fhahn
Copy link

@fhahn fhahn commented Jan 21, 2025

No description provided.

…-phi operand fix. (llvm#121744)

This relands the reverted llvm#120721 with a fix for cases where neither
reduction operand are the reduction phi. Only
6311423 and
6311423 are new on top of the reverted
PR.

---------

Co-authored-by: Nicholas Guy <[email protected]>

(cherry-picked from 795e35a)
This patch introduces lowering of the partial add reduction intrinsic to
a udot or svdot for AArch64. This also involves adding a
`shouldExpandPartialReductionIntrinsic` target hook, which AArch64 will
return false from in the cases that it can be lowered.
…ct (llvm#107078)

This PR adds lowering for fixed-width <4 x i32> and <2 x i32> partial
reductions to a dot product when Neon and the dot product feature are
available.

The work is by Max Beck-Jones (@DevM-uk).
@fhahn fhahn requested a review from a team as a code owner January 21, 2025 11:09
@fhahn
Copy link
Author

fhahn commented Jan 21, 2025

@swift-ci please test

@fhahn
Copy link
Author

fhahn commented Jan 21, 2025

@swift-ci please test llvm

@fhahn
Copy link
Author

fhahn commented Feb 4, 2025

@swift-ci please test

2 similar comments
@fhahn
Copy link
Author

fhahn commented Feb 4, 2025

@swift-ci please test

@fhahn
Copy link
Author

fhahn commented Feb 4, 2025

@swift-ci please test

@fhahn fhahn merged commit a0ef575 into swiftlang:stable/20240723 Feb 5, 2025
5 checks passed
@fhahn fhahn deleted the pick-dotprod branch February 5, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants