[BoundsSafety][NFC] Fix remaining bounds safety test failures in next #9862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l pointers
Previously code like this
```
void receive(int* __counted_by(5));
void test(void) {
receive((int*) NULL);
}
```
would not emit an error diagnostic despite the fact the `test` function
would unconditionally trap.
The problem was that `Expr::isNullPointerConstant` does not look through
explicit casts and so cases where an explicitly NULL pointer constant
was converted to a `__counted_by` or `__sized_by` pointer with a
constant count were not caught.
To fix this `Expr::isNullPointerConstantIgnoreCastsAndOVEs` is used
instead.
rdar://139748843
rapidsna
requested review from
delcypher,
benlangmuir,
hnrklssn and
patrykstefanski
|
@swift-ci test llvm |
rapidsna
force-pushed
the
fix-bounds-safety-test-failures-next
branch
from
43bfd44 to
77cbc4c
Compare
|
@swift-ci please test llvm |
|
Linux PR test failures that might be relevant: |
|
@swift-ci test llvm |
|
@swift-ci test llvm |
benlangmuir
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most failures are addressed by some textual changes in the text. One was due to a missing cherry-pick.