Cp/r139804630 revert wip corefile segment combination pass #9871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvm#106293) Reverts llvm#105442. Due to `TestSkinnyCoreFailing` and root causing of the failure will likely take longer than EOD. (cherry picked from commit b959532)
|
@swift-ci test |
JDevlieghere
approved these changes
Jan 24, 2025
jasonmolenda
deleted the
cp/r139804630-revert-wip-corefile-segment-combination-pass
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a series of patches, reverts, re-applications with fixes to lldb's corefile creation feature when the branch for swift/release/6.1 was created, and we caught the llvm.org main at a point where there was a bug and memory sections would be omitted from corefiles that lldb creates. I looked at cherrypicking the rest of the sequence where this was refined, but it was cleaner to revert the bad commit instead so that's what I'm doing here.
This is the cause of the TestSkinnyCorefile.py test failures we've seen with this branch.
rdar://139804630