[lldb] Fix Swift.Optional formatter behavior when types cannot be res #9909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian-prantl
requested review from
kastiglione,
JDevlieghere,
augusto2112 and
jimingham
|
@swift-ci test |
jimingham
approved these changes
Jan 29, 2025
JDevlieghere
approved these changes
Jan 29, 2025
kastiglione
reviewed
Jan 29, 2025
kastiglione
reviewed
Jan 29, 2025
kastiglione
reviewed
Jan 29, 2025
kastiglione
reviewed
Jan 29, 2025
lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntimeDynamicTypeResolution.cpp
Show resolved
Hide resolved
kastiglione
reviewed
Jan 29, 2025
…olved Previously this formatter would print "nil" as the summary of an optional whose payload could not be resolved in the typesystem, which is very misleading. rdar://143358292
kastiglione
reviewed
Jan 29, 2025
adrian-prantl
force-pushed
the
143358292
branch
from
f363377 to
cbb922c
Compare
|
@swift-ci test |
kastiglione
approved these changes
Jan 29, 2025
|
@swift-ci test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[lldb] Fix Swift.Optional formatter behavior when types cannot be resolved
Previously this formatter would print "nil" as the summary of an
optional whose payload could not be resolved in the typesystem, which
is very misleading.
rdar://143358292