Skip to content

[BoundsSafety][NFC] Upstream BoundsSafetyBringupMissingChecks unit test changes #9926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

delcypher
Copy link

This change modifies the test to pass so it is possible to pass the -fbounds-safety* arguments directly to CC1 (i.e. bypassing the driver) by modifying #if 1 to be #if 0.

rdar://143592184
(cherry picked from commit ca33eac)

…changes

This change modifies the test to pass so it is possible to pass the
`-fbounds-safety*` arguments directly to CC1 (i.e. bypassing the
driver) by modifying `#if 1` to be `#if 0`.

rdar://143592184
(cherry picked from commit ca33eac)
@delcypher delcypher added the clang:bounds-safety Issue relating to the experimental -fbounds-safety feature in Clang label Jan 30, 2025
@delcypher delcypher requested a review from a team as a code owner January 30, 2025 21:25
@delcypher delcypher self-assigned this Jan 30, 2025
@delcypher
Copy link
Author

@swift-ci test llvm

@delcypher
Copy link
Author

@swift-ci test

@delcypher
Copy link
Author

Linux build failure is unrelated to my change.

ools/clang/lib/APINotes/CMakeFiles/obj.clangAPINotes.dir/APINotesYAMLCompiler.cpp.o.d -o tools/clang/lib/APINotes/CMakeFiles/obj.clangAPINotes.dir/APINotesYAMLCompiler.cpp.o -c /home/build-user/llvm-project/clang/lib/APINotes/APINotesYAMLCompiler.cpp
/home/build-user/llvm-project/clang/lib/APINotes/APINotesYAMLCompiler.cpp:218:31: error: declaration of 'std::optional<{anonymous}::BoundsSafety> {anonymous}::Param::BoundsSafety' changes meaning of 'BoundsSafety' [-fpermissive]
  218 |   std::optional<BoundsSafety> BoundsSafety;
      |                               ^~~~~~~~~~~~
/home/build-user/llvm-project/clang/lib/APINotes/APINotesYAMLCompiler.cpp:155:8: note: 'BoundsSafety' declared here as 'struct {anonymous}::BoundsSafety'
  155 | struct BoundsSafety {
      |        ^~~~~~~~~~~~

@hnrklssn Is this build failure related to your work?

@delcypher delcypher merged commit 60d6eec into stable/20240723 Jan 31, 2025
4 of 5 checks passed
@delcypher delcypher deleted the dliew/PR-143592184-cherry-pick-stable-20240723 branch January 31, 2025 21:20
@hnrklssn
Copy link

hnrklssn commented Jan 31, 2025

Linux build failure is unrelated to my change.

ools/clang/lib/APINotes/CMakeFiles/obj.clangAPINotes.dir/APINotesYAMLCompiler.cpp.o.d -o tools/clang/lib/APINotes/CMakeFiles/obj.clangAPINotes.dir/APINotesYAMLCompiler.cpp.o -c /home/build-user/llvm-project/clang/lib/APINotes/APINotesYAMLCompiler.cpp
/home/build-user/llvm-project/clang/lib/APINotes/APINotesYAMLCompiler.cpp:218:31: error: declaration of 'std::optional<{anonymous}::BoundsSafety> {anonymous}::Param::BoundsSafety' changes meaning of 'BoundsSafety' [-fpermissive]
  218 |   std::optional<BoundsSafety> BoundsSafety;
      |                               ^~~~~~~~~~~~
/home/build-user/llvm-project/clang/lib/APINotes/APINotesYAMLCompiler.cpp:155:8: note: 'BoundsSafety' declared here as 'struct {anonymous}::BoundsSafety'
  155 | struct BoundsSafety {
      |        ^~~~~~~~~~~~

@hnrklssn Is this build failure related to your work?

Yeah, I'm trying to revert but I'm having some CI issues preventing merging #9908

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:bounds-safety Issue relating to the experimental -fbounds-safety feature in Clang
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants