[lldb] Wire up reflection support for Builtin.FixedArray #9928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augusto2112
approved these changes
Jan 31, 2025
| return llvm::createStringError("Expected fixed array, but found: " + | ||
| type.GetMangledTypeName().GetString()); | ||
| return ts->RemangleAsType(dem, dem_array_type->getChild(1), | ||
| ts->GetManglingFlavor()); |
There was a problem hiding this comment.
auto flavor = SwiftLanguageRuntime::GetManglingFlavor(
type.GetMangledTypeName().GetStringRef());
return ts->RemangleAsType(dem, dem_array_type->getChild(1), flavor);
There was a problem hiding this comment.
At some point it would be nice to split these functions into smaller functions that deal with the different type info types. GetChildCompilerTypeAtIndex will be almost 400 lines long with this change.
I think the way to go is to factor out common code between GetChildCompilerTypeAtIndex, GetNumChildren, and GetChildMembeWithName.
No test in the testsuite triggeres this code path, except for the new ValueGeneric tes, which triggers it for entirely the wrong reason. I added a new test that exercises the case that is mentioned in the comment to make sure that this is indeed obsolete.
|
@swift-ci test |
adrian-prantl
force-pushed
the
fixed-array-reflection
branch
from
8857333 to
2472c96
Compare
|
@swift-ci test |
|
@swift-ci test windows |
|
@swift-ci test macos |
|
test with swiftlang/swift#79088 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.