[6.1][Index] Skip adding call relations to deduction guides #9949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
commented
Feb 4, 2025
bnbarham
commented
- Explanation: Deduction guides have no name and we already skip adding occurrences to them for that reason. Also skip adding any relations to them.
- Scope: Indexing
- Risk: Low, just skips adding a relation that would otherwise assert
- Tests: Added a new test for the crashing case
- Issues: rdar://142421120
- Reviewers: TBD
- Original PR: [Index] Skip adding call relations to deduction guides #9947
Deduction guides have no name and we already skip adding occurrences to them for that reason. Also skip adding any relations to them. Resolves rdar://142421120. (cherry picked from commit 88c7f03)
|
@swift-ci please test |
airspeedswift
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.