Fixup SourceKit module on Windows #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akyrtzi
suggested changes
Apr 18, 2019
gmittert
force-pushed
the
SourceKitModuleWindows
branch
from
833da5d to
0868c5f
Compare
|
@swift-ci Please test |
akyrtzi
approved these changes
Apr 18, 2019
pvieito
reviewed
Apr 22, 2019
| let pid: Int = unsafeBitCast(GetCurrentProcess(), to: Int.self) | ||
| #else | ||
| let pid: Int = Int(getpid()) | ||
| #endif |
There was a problem hiding this comment.
Why we are reimplementing things already in Foundation?
This could simply be:
let pid = Int(ProcessInfo.processInfo.processIdentifier)Which is already cross-platform.
There was a problem hiding this comment.
Ah fair point, I didn't realize that existed. Plus GetCurrentProcess gives a handle instead of a pid which now that I think about it, is probably the wrong thing to identify a process with. I'll swap it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.