Support creation of SKDRequest(Dictionary|Array) from literals #1008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMO this makes it a lot clearer which keys are present in the request dictionaries because we are no longer mutating them on the fly.
bnbarham
reviewed
Jan 5, 2024
| if let compileCommand = compileCommand { | ||
| req[keys.compilerargs] = compileCommand.compilerArgs | ||
| } | ||
| let req = [ |
There was a problem hiding this comment.
Not a huge fan of skd. What if SKArray/Dictionary both had an initializer that took a sequence/dictionary?
There was a problem hiding this comment.
Changed it to sourcekitd.dictionary(<#dict literal#>)
…ead of using `skd` postfix syntax
|
@swift-ci Please test |
bnbarham
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMO this makes it a lot clearer which keys are present in the request dictionaries because we are no longer mutating them on the fly.