[swiftpm] Stop hard-coding the index store path #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akyrtzi
approved these changes
Nov 17, 2018
fwcd
added a commit
to fwcd/sourcekit-lsp
that referenced
this pull request
Jun 10, 2021
- Add UID for CollectExpressionType request - Add ExpressionTypeInfo structure - Add keys to support sourcekitd's CollectExpressionType - Implement CollectExpressionType request - Add SwiftLanguageServer.expressionTypeInfos - Add InlayHint and supporting types - Add InlayHintsRequest - Add inlayHints handler stub - Implement inlay hints request - Update InlayHint to follow the current proposal - # This is the commit message swiftlang#11: - ...as described in the LSP proposal - Update doc comment on InlayHintsRequest - Map inlay hints lazily - Fix minor style issue - Add new files to CMakeLists.txt - Specify commit of the current inlay hints proposal state - Add public, memberwise initializer for InlayHintsRequest - assert(false) if deserializing ExpressionTypeInfos fails - Add dispatch precondition to _expressionTypeInfos - Add InlayHintsRequest to the builtinRequests - Factor out function for querying document symbols for URI - Only render inlay hints after variable bindings - Test inlay hints on empty document - Test inlay hints for some simple bindings - Test ranged inlay hint requests - Make sure that inlay hints are unique per position - Test inlay hints for fields - Apply various PR suggestions regarding inlay hints - Update inlay hint tests and add case with explicit type annotations - Continue iterating if an ExpressionTypeInfo fails to deserialize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we are using a new enough libSwiftPM, get the path from the API instead of hard-coding it.