Fix test discovery for Objective-C XCTests #1196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
tests-for-objc-xctest
branch
from
bce982f to
aff3a97
Compare
bnbarham
approved these changes
May 1, 2024
ahoppen
force-pushed
the
tests-for-objc-xctest
branch
from
aff3a97 to
45185ff
Compare
ahoppen
changed the title
|
@swift-ci Please test |
ahoppen
force-pushed
the
tests-for-objc-xctest
branch
from
45185ff to
a2d2909
Compare
|
@swift-ci Please test |
ahoppen
force-pushed
the
tests-for-objc-xctest
branch
from
a2d2909 to
c9b0628
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
1 similar comment
|
@swift-ci Please test Windows |
ahoppen
force-pushed
the
tests-for-objc-xctest
branch
from
c9b0628 to
8613f4f
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
There were two issues with Objective-C XCTest discovery: 1. We were relying on syntactic test discovery after a document is edited. But since we don't have syntactic test discovery for Objective-C tests, this meant that all tests would disappear as a document got edited. Until we get syntactic test discovery for Objective-C, use the semantic index to discover tests, even if they are out-of-date. 2. We were assuming that the `DocumentSymbols` request returned `[DocumentSymbol]` to find the ranges of tests. But clangd returns the alternative `[SymbolInformation]`, which meant that we were only returning the position of a test function’s name instead of the test function’s range. rdar://126810202
ahoppen
force-pushed
the
tests-for-objc-xctest
branch
from
8613f4f to
6a9a95f
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
1 similar comment
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two issues with Objective-C XCTest discovery:
DocumentSymbolsrequest returned[DocumentSymbol]to find the ranges of tests. But clangd returns the alternative[SymbolInformation], which meant that we were only returning the position of a test function’s name instead of the test function’s range.rdar://126810202