Skip to content

[6.0][build-script-helper] Prefer just-built plugins to SDK plugins #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2024

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented May 4, 2024

Cherry-pick #1221 into release/6.0

  • Explanation: Add -Xswiftc -plugin-path -Xswiftc ${toolchain}/lib/swift/host/plugins to SwiftPM invocations. This is a workaround for building fat binaries with Xcode build system being old.
  • Scope: Toolchain building
  • Risk: Low, new swift-driver does the same thing. This emulates the behavior just for sourcekit-lsp building with Xcode
  • Testing: Confirmed toolchain builds succeeds with this change.
  • Issue: N/A
  • Reviewer: Ben Barham (@bnbarham)

Add '-Xswiftc -plugin-path -Xswiftc ${toolchain}/lib/swift/host/plugins'
to swiftpm invocations.

(cherry picked from commit 555df60)
@rintaro
Copy link
Member Author

rintaro commented May 4, 2024

@swift-ci Please test

@rintaro rintaro enabled auto-merge May 4, 2024 02:14
@rintaro rintaro merged commit 0ccbf68 into swiftlang:release/6.0 May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants