Update index as files are modified on disk #1302
Conversation
|
@swift-ci Please test |
ahoppen
force-pushed
the
watch-file-changes-index
branch
from
37d23f5 to
e215736
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
| We mark the targets of the changed file as well as any dependent targets as out-of-date. The assumption is that most likely the user will go back to any of the affected files shortly afterwards and modify them again. When that happens, the affected file will get re-indexed and bring the index back up to date. | ||
|
|
||
| Alternatives would be: | ||
| - We could we check the file’s interface hash and re-index other files based on whether it has changed. But at that point we are somewhat implementing a build system. And even if a new public method was introduced it’s very likely that the user hasn’t actually used it anywhere yet, which means that re-indexing all dependent modules would still be doing unnecessary work. |
There was a problem hiding this comment.
I wonder, with fine enough dependencies and swift-driver support, whether some kind of incremental-mode-based indexing could make sense. But that's way off in the future 😄
There was a problem hiding this comment.
Even if we had it, I’m not sure if we really want to do a whole downstream re-index. Say you add a new public function in a fairly low-level module then we would need to re-index the entire project based on incremental information because it might affect overload resolution. And that’s still quite a bit of work, considering that most likely nothing really changed.
There was a problem hiding this comment.
It depends how fine grained the dependencies are, in theory if you're adding a function called foo, you shouldn't need to rebuild anything that didn't do a lookup for foo
There was a problem hiding this comment.
That’s a dream for a far and bright future ✨
Fixes swiftlang#1251 rdar://127476161
ahoppen
force-pushed
the
watch-file-changes-index
branch
from
e215736 to
546bb32
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
1 similar comment
|
@swift-ci Please test Windows |
Address review comments to #1302
Fixes #1251
rdar://127476161