Skip to content

Ensure that the indexstore-db is up-to-date before deciding which source files we need to re-index #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented May 24, 2024

Waiting for the indexstore-db to be updated is cheaper than potentially not knowing about unit files, which causes the corresponding source files to be re-indexed.

rdar://128645743

@ahoppen ahoppen requested review from bnbarham and hamishknight May 24, 2024 06:15
@ahoppen ahoppen requested a review from benlangmuir as a code owner May 24, 2024 06:15
@ahoppen
Copy link
Member Author

ahoppen commented May 24, 2024

@swift-ci Please test

…rce files we need to re-index

Waiting for the indexstore-db to be updated is cheaper than potentially not knowing about unit files, which causes the corresponding source files to be re-indexed.

rdar://128645743
@ahoppen ahoppen force-pushed the update-indexstore-db-before-deciding-what-to-index branch from 0069f67 to 4ad6eb3 Compare May 24, 2024 06:22
@ahoppen
Copy link
Member Author

ahoppen commented May 24, 2024

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented May 24, 2024

@swift-ci Please test Windows

@ahoppen ahoppen merged commit 7fbb39e into swiftlang:main May 24, 2024
3 checks passed
@ahoppen ahoppen deleted the update-indexstore-db-before-deciding-what-to-index branch May 24, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants