Address review comments from #1322 and #1329 #1349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
bnbarham
approved these changes
May 24, 2024
| Show which index tasks are currently running in the indexing work done progress. \ | ||
| This produces a multi-line work done progress, which might render incorrectly depending in the editor. | ||
| When reporting index progress, show the currently running index tasks in addition to the task's count. \ | ||
| This produces a multi-line work done progress, which might render incorrectly, depending in the editor. |
There was a problem hiding this comment.
Suggested change
| This produces a multi-line work done progress, which might render incorrectly, depending in the editor. | |
| This produces a multi-line work done progress, which might render incorrectly, depending on the editor. |
ahoppen
force-pushed
the
address-review-comments-1322-1329
branch
from
7b79431 to
8810dbe
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
ahoppen
force-pushed
the
address-review-comments-1322-1329
branch
from
8810dbe to
8772ccf
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
|
@swift-ci Please test Linux |
ahoppen
force-pushed
the
address-review-comments-1322-1329
branch
from
8772ccf to
9098e09
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
|
@swift-ci Please test Linux |
1 similar comment
|
@swift-ci Please test Linux |
hamishknight
approved these changes
May 28, 2024
|
@swift-ci Please test Linxu |
|
@swift-ci Please test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.