Skip to content

Don’t re-index files in languages that cannot be indexed #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2024

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented May 25, 2024

Swift packages can have source files that we can’t index (like assembly files). When re-opening, we schedule indexing for those files, which requires the targets to be re-prepared. We skip them earlier.

rdar://128711633

Swift packages can have source files that we can’t index (like assembly files). When re-opening, we schedule indexing for those files, which requires the targets to be re-prepared. We skip them earlier.

rdar://128711633
@ahoppen ahoppen requested review from bnbarham and hamishknight May 25, 2024 00:14
@ahoppen ahoppen requested a review from benlangmuir as a code owner May 25, 2024 00:14
@ahoppen
Copy link
Member Author

ahoppen commented May 25, 2024

@swift-ci Please test

@ahoppen ahoppen merged commit 5d75e14 into swiftlang:main May 25, 2024
3 checks passed
@ahoppen ahoppen deleted the dont-reindex branch May 25, 2024 20:41
@hamishknight
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants