Add a few more arguments to allow errors during indexing #1384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that we were missing a bunch more arguments (in particular for clang index invocations), while diagnosing rdar://129071600, which is fixed by passing `-experimental-allow-module-with-compiler-errors` to the Swift index invocations. rdar://129071600
|
@swift-ci Please test |
hamishknight
reviewed
Jun 3, 2024
Comment on lines
-433
to
-437
| let removeFrontendFlags = [ | ||
| "-experimental-skip-non-inlinable-function-bodies", | ||
| "-experimental-skip-all-function-bodies", | ||
| ] | ||
|
|
There was a problem hiding this comment.
Don't we want to remove these for indexing?
There was a problem hiding this comment.
They would presumably only be there if we added them, which we're currently. not. Probably doesn't hurt to keep anyway though.
bnbarham
reviewed
Jun 3, 2024
|
|
||
| func testImportPreparedModuleWithFunctionBodiesSkipped() async throws { | ||
| // This test case was crashing the indexing compiler invocation for Client if Lib was built for index preparation | ||
| // (using `-enable-library-evolution -experimental-skip-all-function-bodies -experimental-lazy-typecheck`) but x |
Comment on lines
-433
to
-437
| let removeFrontendFlags = [ | ||
| "-experimental-skip-non-inlinable-function-bodies", | ||
| "-experimental-skip-all-function-bodies", | ||
| ] | ||
|
|
There was a problem hiding this comment.
They would presumably only be there if we added them, which we're currently. not. Probably doesn't hurt to keep anyway though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that we were missing a bunch more arguments (in particular for clang index invocations), while diagnosing rdar://129071600, which is fixed by passing
-experimental-allow-module-with-compiler-errorsto the Swift index invocations.rdar://129071600