Skip to content

Skip testImportPreparedModuleWithFunctionBodiesSkipped if toolchain doesn’t support rename #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jun 1, 2024

The test uses rename and should thus be skipped if sourcekitd doesn’t support rename.

This makes the tests pass with Xcode 15.4.

…oesn’t support rename

The test uses rename and should thus be skipped if sourcekitd doesn’t support rename.
@ahoppen ahoppen requested review from bnbarham and hamishknight June 1, 2024 05:05
@ahoppen ahoppen requested a review from benlangmuir as a code owner June 1, 2024 05:05
@ahoppen
Copy link
Member Author

ahoppen commented Jun 1, 2024

@swift-ci Please test

@ahoppen ahoppen merged commit d6a72ef into swiftlang:main Jun 1, 2024
3 checks passed
@ahoppen ahoppen deleted the test-pass-with-xcode-15-4 branch June 1, 2024 13:18
Copy link
Contributor

@hamishknight hamishknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants